fix(audit): bind subscribe to live plan terms (MULT-6)#35
Merged
dev-jodee merged 6 commits intoApr 28, 2026
Conversation
Compute Unit Report
Generated: 2026-04-28 |
5 tasks
Extend SubscribeData with expected_mint/amount/period_hours/created_at. Program rejects with PlanTermsMismatch if the live plan disagrees with what the subscriber signed. Stale-signed subscribe transactions can no longer enroll into a recreated plan with different terms. SDK and webapp callers fetch plan data and pass the snapshot.
dev-jodee
force-pushed
the
audit/ai-scanner/06-subscribe-terms-binding
branch
from
33dfaf3 to
9a6c2b0
Compare
Plan::check_destination and Plan::can_pull now filter out zero-padded slots before membership tests. A plan with fewer than four configured destinations no longer authorizes a zero-owned receiver, and a plan with fewer than four pullers no longer authorizes a zero-pubkey caller.
…-10) Webapp exit flows now pass the on-chain payer as receiver when it differs from the connected signer, so sponsor-funded delegations and SubscriptionAuthority accounts can actually be closed. Also migrates revokeSubscription and cancelAndRevokeSubscription from buildRevokeDelegation to buildRevokeSubscription with planPda + receiver, fixing subscription revoke for both sponsor and non-sponsor cases.
…(MULT-9) Stale-delegation cleanup no longer appends a close on the current SubscriptionAuthority. Revoking stale delegations is now scoped to the supplied delegation accounts; the SA stays open and current grants remain valid.
dev-jodee
merged commit 3b4e62c
into
audit/ai-scanner/05-sponsor-revoke-drift
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit finding: MULT-6
A subscriber's pre-signed
subscribetransaction could be enrolled into a recreated plan with different terms. The instruction did not bind the subscriber's intent to the plan terms they consented to at signing time, so a merchant who deleted and recreated the plan with a different amount, period, or mint could capture an old signed subscribe and lock the subscriber into the new terms.Fix
SubscribeDatanow carries the four plan fields that determine financial commitment:expected_mint: Addressexpected_amount: u64expected_period_hours: u64expected_created_at: i64After loading the live plan,
subscribe::processrejects withPlanTermsMismatchif any field disagrees.Consumers updated
clients/typescriptbuildSubscriberequires the four expected_* paramssubscribemutation takes them andplan-card.tsxpasses from the live planapps/webSubscribe form exposes them as fields (low-level dev tool)Subscribe::executesnapshots live plan termsTest plan
cargo build -p subscriptionscargo test -p subscriptions --lib(213/213 pass; one new regression test)subscribe_rejects_stale_expected_termsasserts mismatched expected_amount returnsPlanTermsMismatchpnpm --filter @subscriptions/client buildpnpm exec tsc --noEmitin webapp and apps/webStack
Stacked on top of #34 (MULT-5).